[PATCH] Copy data files to the remote runner.

Eric Fiselier eric at efcs.ca
Fri Mar 6 12:17:41 PST 2015


LGTM as long as the inline comment is addressed.

Is there rational for just not requiring that the source tree be checked out on the target already? I haven't looked to hard at this executor stuff but that seems like it might solve some of these problems.


REPOSITORY
  rL LLVM

================
Comment at: test/libcxx/test/executor.py:116
@@ -115,2 +115,3 @@
             target_cwd = self.remote_temp_dir()
+            target_exe_path = os.path.join(target_cwd, 'libcxx_test')
             if cmd:
----------------
Is is possible that two tests could be run in parallel and try and use the same path?

http://reviews.llvm.org/D8118

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list