[PATCH] [libcxx] Checking LIT benchmark testing framework.

[Dmitri Gribenko]

On Fri, Mar 6, 2015 at 11:29 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
>
> On Fri, Mar 6, 2015 at 10:21 AM, hfinkel at anl.gov <hfinkel at anl.gov> wrote:
>>
>> Almost none of my benchmarking machines can initiate outgoing connections,
>> so I'd need to download/checkout the Google 'benchmark' library manually.
>> Can you please add some comments about exactly what should be retrieved, and
>> where it should be put.
>
>
> The entire thing seems odd.
>
> I would much rather just have the benchmark code live in some utility place
> in one of the repositories. For example, we keep gtest in utils/unittest in
> the LLVM repository. I wonder if we could check the benchmark stuff into
> utils/benchmark, and add it to CMake normally.
>
> Then the benchmarks can be built normally with CMake (or Makefiles) and LIT
> can just be responsible for actually running them.
>
> This would make the benchmarks unavailable from a stand-alone build of
> libc++ but that seems a not-terrible tradeoff.

+1 from me.  It would be great to have a benchmarking framework
in-tree so that other projects could use it.  For example, we could
have latency tests for Clang code completion or re-parsing with
implicit PCH.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/