[PATCH] Add readability-simplify-boolean-expr check to clang-tidy

Alexander Kornienko alexfh at google.com
Wed Mar 4 02:40:12 PST 2015


On Tue, Mar 3, 2015 at 11:07 PM, Richard <legalize at xmission.com> wrote:

> Thanks for the comments.  I apologize for having to make the same comment
> repeatedly; I find it difficult to match up all the open issues in
> phabricator.  I'm used to review board where such things are easier to
> manage.  I try to work through the open issues, but since they are mixed in
> with earlier diffs and there's no way for me to mark an issue  as fixed in
> phabricator, it makes me manually go through everything and make sure I got
> them and I end up missing some items.  Please bear with me and have
> patience :).


I find it useful to reply on each inline comment (instead of a summary in a
single place). This way you usually can see whether there are comment
threads where the last reply isn't yours. These are usually what you need
to address (and reply to, probably with a single "Done." word).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150304/e4023d9d/attachment.html>


More information about the cfe-commits mailing list