r231008 - [SDK modernizer]. Patch fixes driver's lack of

[Chandler Carruth]

On Tue, Mar 3, 2015 at 9:18 AM, jahanian <fjahanian at apple.com> wrote:

> On Mar 3, 2015, at 1:28 AM, Chandler Carruth <chandlerc at google.com> wrote:
>
>
> This isn't really the right way to test the driver.
>
> We usually test changes to the driver by adding a test under 'test/Driver'
> and using '-###' in conjunction with FileCheck to assert on the commandline
> formed by the driver.
>
> Among other things, by using the driver here rather than the cc1 layer you
> have the following problems:
>
> - you have to carefully manage the -fobc-arc flags as you've already had
> to tweak in subsequent commits
> - on non-x86 platforms the driver may end up producing very flawed cc1
> invocations in conjunction with the hard-coded cc1 flags of '-Xclang
> -triple -Xclang x86_64-apple-darwin11'
>
> At least for non-x86 platforms, this is actually a breaking change and we
> need to revert it to get builds green again.
>
>
> New test in r231080.
>

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150303/9a178747/attachment.html>