[PATCH] CodeGen: Emit constant array temporaries into read-only globals.
Rafael EspĂndola
rafael.espindola at gmail.com
Tue Mar 3 11:33:47 PST 2015
>> In this case the ComdatGV would be the function, which is not private, no?
>
>
> I was referring to the case where the function has internal linkage (and we
> have EmitUniquedSection enabled for data sections). The global would be
> private and it wouldn't be possible to stick it in a COMDAT.
I don't follow, if the function is internal, ComdatGV will be the
function and have internal linkage, no?
In any case, if there is a CodeGen limitation for COFF, using internal
for COFF and private for MachO/ELF for now is probably fine.
I will try to open a bug to track "private in comdat for COFF".
Cheers,
Rafael
More information about the cfe-commits
mailing list