r231009 - Improve robustness of dependency-generation-crash.c test.

[Daniel Jasper]

Thanks for fixing :-)

On Tue, Mar 3, 2015 at 1:15 AM, Matthias Braun <matze at braunis.de> wrote:

> No, thanks for mentioning it.
>
> - Matthias
>
> On Mar 2, 2015, at 4:09 PM, Daniel Jasper <djasper at google.com> wrote:
>
> Are you intentionally using %t and $t?
>
> On Mon, Mar 2, 2015 at 9:44 PM, Matthias Braun <matze at braunis.de> wrote:
>
>> Author: matze
>> Date: Mon Mar  2 14:44:09 2015
>> New Revision: 231009
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=231009&view=rev
>> Log:
>> Improve robustness of dependency-generation-crash.c test.
>>
>> The test wants to provoke a failure when opening the output file.
>> Using chmod 0 on the output file does not work reliably on all
>> filesystems or when running the test as root.
>> Change the test to use a nonexistant directory instead.
>>
>> Differential Revision: http://reviews.llvm.org/D7620
>>
>> Modified:
>>     cfe/trunk/test/Frontend/dependency-generation-crash.c
>>
>> Modified: cfe/trunk/test/Frontend/dependency-generation-crash.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/dependency-generation-crash.c?rev=231009&r1=231008&r2=231009&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/Frontend/dependency-generation-crash.c (original)
>> +++ cfe/trunk/test/Frontend/dependency-generation-crash.c Mon Mar  2
>> 14:44:09 2015
>> @@ -1,7 +1,4 @@
>> -// RUN: touch %t
>> -// RUN: chmod 0 %t
>> -// RUN: not %clang_cc1 -E -dependency-file bla -MT %t -MP -o %t -x c
>> /dev/null 2>&1 | FileCheck %s
>> -// RUN: rm -f %t
>> +// RUN: not %clang_cc1 -E -dependency-file bla -MT %t/doesnotexist/bla.o
>> -MP -o $t/doesnotexist/bla.o -x c /dev/null 2>&1 | FileCheck %s
>>
>>  // CHECK: error: unable to open output file
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150303/0ba99048/attachment.html>