[PATCH] [libcxxabi] Build both static and shared versions of libc++abi by default.

[Eric Fiselier]

Address inline comments.


================
Comment at: src/CMakeLists.txt:83
@@ -91,1 +82,3 @@
+# Add a object library that contains the compiled source files.
+add_library(cxxabi_sources OBJECT ${LIBCXXABI_SOURCES} ${LIBCXXABI_HEADERS})
 
----------------
compnerd wrote:
> This is a weird name.  It is rather misleading as well.  I get why you are doing the object library (no need to rebuild the objects).  Perhaps cxxabi_OBJECTS ?  Given that you are changing the name of the target from cxxabi to cxxabi_{shared,static}, cxxabi would be even better.  Specially when you use the generator expression below ($<TARGET_OBJECTS:cxxabi>).
I'll change to `cxxabi_OBJECTS`. I want to save `cxxabi` as a target name that builds both `cxxabi_shared` and `cxxabi_static`. 

================
Comment at: src/CMakeLists.txt:90
@@ -100,2 +89,3 @@
 
-install(TARGETS cxxabi
+set(LIBCXXABI_TARGETS "")
+
----------------
compnerd wrote:
> Better written as:
> 
>   set(LIBCXXABI_TARGETS)
Cool, didn't know you could do that. Thanks.

http://reviews.llvm.org/D8013

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/