[PATCH] Add Clang support for PPC cryptography builtins
Bill Schmidt
wschmidt at linux.vnet.ibm.com
Mon Mar 2 11:48:23 PST 2015
Hi Nemanja,
Please see inline comment. The -mcrypto enablement is not quite right -- probably need to fix this up and resubmit. Sorry. :/
REPOSITORY
rL LLVM
================
Comment at: lib/Basic/Targets.cpp:981
@@ -967,1 +980,3 @@
+ // The default with -mcpu=pwr8 is to enable both (as is the case with gcc).
+ // See: http://reviews.llvm.org/D7951
for (unsigned i = 0, e = Features.size(); i !=e; ++i) {
----------------
Mm, I don't want you to mimic current gcc behavior regarding -mcrypto. Current gcc behavior is wrong and must be brought into compliance. -mcrypto should turn on only the SHA and AES instructions (the same ones that -mno-crypto disables). Sorry if this was unclear, but we don't want to get into a confusing state where -mcrypto is not the opposite of -mno-crypto.
http://reviews.llvm.org/D7951
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list