[clang-tools-extra] r230982 - clang-tidy: Update test as underlying problem apparently was fixed.

Alexander Kornienko alexfh at google.com
Mon Mar 2 10:17:29 PST 2015


The problem in YAML parser was actually fixed in r230976.

On Mon, Mar 2, 2015 at 7:07 PM, Daniel Jasper <djasper at google.com> wrote:

> Author: djasper
> Date: Mon Mar  2 12:07:00 2015
> New Revision: 230982
>
> URL: http://llvm.org/viewvc/llvm-project?rev=230982&view=rev
> Log:
> clang-tidy: Update test as underlying problem apparently was fixed.
>
> Modified:
>     clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyOptionsTest.cpp
>
> Modified:
> clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyOptionsTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyOptionsTest.cpp?rev=230982&r1=230981&r2=230982&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyOptionsTest.cpp
> (original)
> +++ clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyOptionsTest.cpp
> Mon Mar  2 12:07:00 2015
> @@ -15,8 +15,7 @@ TEST(ParseLineFilter, EmptyFilter) {
>
>  TEST(ParseLineFilter, InvalidFilter) {
>    ClangTidyGlobalOptions Options;
> -  // TODO: Figure out why parsing succeeds here.
> -  EXPECT_FALSE(parseLineFilter("asdf", Options));
> +  EXPECT_TRUE(!!parseLineFilter("asdf", Options));
>    EXPECT_TRUE(Options.LineFilter.empty());
>
>    EXPECT_TRUE(!!parseLineFilter("[{}]", Options));
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150302/808cacf6/attachment.html>


More information about the cfe-commits mailing list