[PATCH] [clang-tidy] Assert related checkers

[Alexander Kornienko]

Committed revision 230943.

A few changes before commit:

- Fixed a couple of issues I noticed (see the comments).
- Removed some top-level consts for consistency with the rest of clang-tidy code (and other reasons I mentioned earlier in reviews).

Thank you for contributing these checks!


================
Comment at: clang-tidy/misc/AssertSideEffectCheck.cpp:76
@@ +75,3 @@
+      RawAssertList(Options.get("AssertMacros", "assert")) {
+  StringRef SR = RawAssertList;
+  SR.split(AssertMacros, ",", -1, false);
----------------
nit: This can be a temporary.

================
Comment at: clang-tidy/misc/AssertSideEffectCheck.h:30
@@ +29,3 @@
+///   macros to be checked.
+///   The names are separated by commas. Do not use other delimiter
+///   like whitespace, semicolon.
----------------
This part of the comment is redundant since we already said that this is a comma-separated list.

http://reviews.llvm.org/D7375

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/