[PATCH] Add .eh_frame_hdr search to Linux unwinder.
Saleem Abdulrasool
compnerd at compnerd.org
Fri Feb 27 14:03:42 PST 2015
Looks like it should be okay beyond the inline comments.
REPOSITORY
rL LLVM
================
Comment at: src/Unwind/EHHeaderParser.hpp:34
@@ +33,3 @@
+ struct EHHeaderInfo {
+ pint_t ehFramePtr;
+ size_t fdeCount;
----------------
Can you change these to the specification specified names? It makes it easier to cross-reference.
================
Comment at: src/Unwind/config.h:86
@@ -85,3 +85,3 @@
#define _LIBUNWIND_SUPPORT_COMPACT_UNWIND 0
- #define _LIBUNWIND_SUPPORT_DWARF_UNWIND 0
- #define _LIBUNWIND_SUPPORT_DWARF_INDEX 0
+ #define _LIBUNWIND_SUPPORT_DWARF_UNWIND !defined(__arm__) || \
+ defined(__ARM_DWARF_EH__)
----------------
Does clang-format format this statement this way?
http://reviews.llvm.org/D6848
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list