[PATCH] Don't crash on leaving nested __finally blocks through an EH edge.
Reid Kleckner
rnk at google.com
Thu Feb 26 14:05:46 PST 2015
I have one idea for how we can still be clever, but if it's too hard, then yeah let's be dumb.
================
Comment at: lib/CodeGen/CGException.cpp:1936
@@ -1935,3 @@
- if (!HaveInsertPoint()) {
- FI.ContBB->eraseFromParent();
- if (FI.ResumeBB)
----------------
Can we check !HaveInsertPoint() && FI.ContBB->hasZeroUses() instead and still be clever?
http://reviews.llvm.org/D7918
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list