[PATCH] CodeGen: convert double -> __fp16 in one step

Andrea Di Biagio Andrea_DiBiagio at sn.scee.net
Tue Feb 24 11:20:31 PST 2015


Hi Ahmed,

The patch looks good to me. However, I don't think I am knowledgeable enough to give the final approval. So, somebody else should review this patch.

My personal opinion (for what is worth..) is that this is the correct approach. On X86, I am not particularly worried about the extra runtime libcalls which could be generated for double-to-half conversions. Also, (as you already know) the target independent legalizer now knows how to split a double-to-half conversion into the sequence 'double-to-float' plus 'float-to-half' (only under fast-math).


http://reviews.llvm.org/D4602

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list