r229680 - Change representation of member function pointers for MIPS targets
Zoran Jovanovic
Zoran.Jovanovic at imgtec.com
Mon Feb 23 08:33:24 PST 2015
Hello Anton,
"arm" is a typo. My mistake. I will fix this. Sorry for inconvenience.
Test case:
test/CodeGenCXX/member-function-pointers.cpp
It is extended with new RUN line for MIPS. New representation of pointer to member function is the same as for ARM.
This patch fixes an issue with MultiSource/Benchmarks/Bullet test when compiled for microMIPS.
Review was done here:
http://reviews.llvm.org/D7148
Regards,
Zoran
________________________________________
From: Anton Korobeynikov [anton at korobeynikov.info]
Sent: Monday, February 23, 2015 4:18 PM
To: Zoran Jovanovic
Cc: cfe-commits
Subject: Re: r229680 - Change representation of member function pointers for MIPS targets
> --- cfe/trunk/lib/Basic/TargetInfo.cpp (original)
> +++ cfe/trunk/lib/Basic/TargetInfo.cpp Wed Feb 18 09:21:35 2015
> @@ -655,6 +655,7 @@ bool TargetCXXABI::tryParse(llvm::String
> .Case("ios", iOS)
> .Case("itanium", GenericItanium)
> .Case("microsoft", Microsoft)
> + .Case("arm", GenericMIPS)
> .Default(unknown);
> if (kind == unknown) return false;
Why "arm" here? Did anyone reviewed this patch? Where are the tests?
--
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
More information about the cfe-commits
mailing list