[clang-tools-extra] r229855 - Pruned some unneeded code and comments.

John Thompson John.Thompson.JTSoftware at gmail.com
Thu Feb 19 06:31:49 PST 2015


Author: jtsoftware
Date: Thu Feb 19 08:31:48 2015
New Revision: 229855

URL: http://llvm.org/viewvc/llvm-project?rev=229855&view=rev
Log:
Pruned some unneeded code and comments.

Modified:
    clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp
    clang-tools-extra/trunk/modularize/ModularizeUtilities.h

Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp?rev=229855&r1=229854&r2=229855&view=diff
==============================================================================
--- clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp (original)
+++ clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp Thu Feb 19 08:31:48 2015
@@ -214,7 +214,7 @@ std::error_code ModularizeUtilities::loa
 
 // Collect module map headers.
 // Walks the modules and collects referenced headers into
-// ModuleMapHeadersSet.
+// HeaderFileNames.
 bool ModularizeUtilities::collectModuleMapHeaders(clang::ModuleMap *ModMap) {
   for (ModuleMap::module_iterator I = ModMap->module_begin(),
     E = ModMap->module_end();
@@ -227,7 +227,7 @@ bool ModularizeUtilities::collectModuleM
 
 // Collect referenced headers from one module.
 // Collects the headers referenced in the given module into
-// HeaderFileNames and ModuleMapHeadersSet.
+// HeaderFileNames.
 bool ModularizeUtilities::collectModuleHeaders(const Module &Mod) {
 
   // Ignore explicit modules because they often have dependencies
@@ -248,7 +248,6 @@ bool ModularizeUtilities::collectModuleH
     std::string HeaderPath = getCanonicalPath(UmbrellaHeader->getName());
     // Collect umbrella header.
     HeaderFileNames.push_back(HeaderPath);
-    ModuleMapHeadersSet.insert(HeaderPath);
 
     // FUTURE: When needed, umbrella header header collection goes here.
   }
@@ -306,7 +305,6 @@ bool ModularizeUtilities::collectUmbrell
       continue;
     // Save header name.
     std::string HeaderPath = getCanonicalPath(File);
-    ModuleMapHeadersSet.insert(HeaderPath);
     Dependents.push_back(HeaderPath);
   }
   return true;

Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.h
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/ModularizeUtilities.h?rev=229855&r1=229854&r2=229855&view=diff
==============================================================================
--- clang-tools-extra/trunk/modularize/ModularizeUtilities.h (original)
+++ clang-tools-extra/trunk/modularize/ModularizeUtilities.h Thu Feb 19 08:31:48 2015
@@ -50,8 +50,6 @@ public:
   llvm::SmallVector<std::string, 32> HeaderFileNames;
   /// Map of top-level header file dependencies.
   DependencyMap Dependencies;
-  /// Set of all the headers found in the module map.
-  llvm::StringSet<llvm::MallocAllocator> ModuleMapHeadersSet;
 
   // Functions.
 
@@ -93,14 +91,14 @@ protected:
 
   /// Collect module Map headers.
   /// Walks the modules and collects referenced headers into
-  /// ModuleMapHeadersSet.
+  /// HeaderFileNames.
   /// \param ModMap A loaded module map object.
   /// \return True if no errors.
   bool collectModuleMapHeaders(clang::ModuleMap *ModMap);
 
   /// Collect referenced headers from one module.
   /// Collects the headers referenced in the given module into
-  /// HeaderFileNames and ModuleMapHeadersSet.
+  /// HeaderFileNames.
   /// \param Mod The module reference.
   /// \return True if no errors.
   bool collectModuleHeaders(const clang::Module &Mod);





More information about the cfe-commits mailing list