[PATCH] Add readability-remove-void-arg check to clang-tidy

[Gábor Horváth]

Hi!

As far as I know this is not a valid transformation for C. I think you should check lang options whether the processed file is compiled in C or in C++ mode. (At least I did not find the check at the first glance.)

Regards,
Gábor


================
Comment at: clang-tidy/readability/RemoveVoidArg.cpp:169
@@ +168,3 @@
+void RemoveVoidArg::processTypedefDecl(const MatchFinder::MatchResult &Result, TypedefDecl const *const Typedef) {
+    std::string const Text = getText(Result, *Typedef);
+    removeVoidArgumentTokens(Result, Typedef->getLocStart(), Text, "Redundant void argument list in typedef.");
----------------
I think in the LLVM codebase consts tend to be written before the type and not after.

http://reviews.llvm.org/D7639

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/