[PATCH] Make the unwinder build on thumbv6-m with the integrated assembler.
Saleem Abdulrasool
compnerd at compnerd.org
Fri Feb 13 17:05:39 PST 2015
LGTM with the one inline comment.
================
Comment at: UnwindRegistersSave.S:320
@@ +319,3 @@
+#if __ARM_ARCH_ISA_THUMB1 == 1
+ movs r0, #0 @ return UNW_ESUCCESS
+#else
----------------
A comment to indicate that the non-setting version is not available in T1 would ensure that someone coming along wouldn't try to merge this together.
http://reviews.llvm.org/D7630
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list