[PATCH] Make the unwinder build on thumbv6-m with the integrated assembler.
Saleem Abdulrasool
compnerd at compnerd.org
Fri Feb 13 15:46:45 PST 2015
================
Comment at: UnwindRegistersSave.S:310
@@ -309,2 +309,3 @@
str r3, [r0, #60] @ store return address as pc
+ movs r0, #0 @ return UNW_ESUCCESS
#else
----------------
How about doing:
#if __ARM_ARCH_ISA_THUMB == 1
movs r0, #0
#else
mov r0, #0
#endif
I don't see why we should have the side-effect if we can avoid it.
http://reviews.llvm.org/D7630
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list