[PATCH] Improve robustness of dependency-generation-crash.c test.

Matthias Braun matze at braunis.de
Fri Feb 13 11:28:15 PST 2015


Hi mcrosier,

The test wants to provoke a failure when opening the output file.
Using chmod 0 on the output file does not work reliably on all
filesystems or when running the test as root.
Change the test to use a nonexistant directory instead.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7620

Files:
  test/Frontend/dependency-generation-crash.c

Index: test/Frontend/dependency-generation-crash.c
===================================================================
--- test/Frontend/dependency-generation-crash.c
+++ test/Frontend/dependency-generation-crash.c
@@ -1,7 +1,4 @@
-// RUN: touch %t
-// RUN: chmod 0 %t
-// RUN: not %clang_cc1 -E -dependency-file bla -MT %t -MP -o %t -x c /dev/null 2>&1 | FileCheck %s
-// RUN: rm -f %t
+// RUN: not %clang_cc1 -E -dependency-file bla -MT /thisX/doesXX/not/exist/bla.o -MP -o /thisX/doesXX/not/exist/bla.o -x c /dev/null 2>&1 | FileCheck %s
 
 // CHECK: error: unable to open output file

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7620.19911.patch
Type: text/x-patch
Size: 590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150213/b9999765/attachment.bin>


More information about the cfe-commits mailing list