[PATCH] Split the TargetInfo stuff from D7380 into its own patch.
Dan Albert
danalbert at google.com
Thu Feb 12 21:10:20 PST 2015
LGTM
================
Comment at: libcxx/test/config.py:111
@@ +110,3 @@
+ def configure_target_info(self):
+ info_str = self.get_lit_conf('target_info', "None")
+ self.target_info = eval(info_str)
----------------
I'd prefer `importlib` + `getattr` instead of `eval`.
http://reviews.llvm.org/D7601
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list