[PATCH] Add remote testing support to the lit config.
Jonathan Roelofs
jonathan at codesourcery.com
Thu Feb 12 15:43:28 PST 2015
I split the TargetInfo part into its own patch: http://reviews.llvm.org/D7601
This patch will need a slight rebase after that goes in.
================
Comment at: libcxx/test/config.py:471
@@ -434,1 +470,3 @@
+ target_platform = self.target_info.platform()
+ if target_platform == 'Darwin':
self.cxx.link_flags += ['-lSystem']
----------------
I think this needs to stay as lowercase, actually.
================
Comment at: test/libcxx/test/config.py:128
@@ +127,3 @@
+ # that the user wants it at the end, but we have no
+ # way of getting at that easily.
+ selt.lit_config.fatal("Cannot infer how to create a Valgrind "
----------------
danalbert wrote:
> `useValgrind` should just go away. If the user wants valgrind, they can add the `ValgrindExecutor` themselves.
This suggestion is a buildbot-breaking change. Can clean this up after any zorg bots that care about valgrind are moved over to using the new cmake flag.
================
Comment at: test/libcxx/test/config.py:120
@@ +119,3 @@
+ def configure_target_executor(self):
+ exec_str = self.get_lit_conf('target_executor', None)
+ if exec_str:
----------------
EricWF wrote:
> Isn't this always set to the default by CMake?
Oh yeah.
================
Comment at: test/libcxx/test/config.py:122
@@ +121,3 @@
+ if exec_str:
+ print exec_str
+ self.target_executor = eval(exec_str)
----------------
EricWF wrote:
> Remove this. Use the lit_config reporting methods.
oops
http://reviews.llvm.org/D7380
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list