[Patch for libcxxabi] Don't use bzero() and prevent unneeded copying
Jonathan Roelofs
jroelofs.lists at gmail.com
Thu Feb 12 14:01:30 PST 2015
On 2/12/15 9:42 AM, Ed Schouten wrote:
> Hi there,
>
> While building libcxxabi on a new platform (more news on that later :-),
:D Exciting! (and interesting too, given the two places where your patch
touches).
> I noticed libcxxabi uses bzero() in a single place, causing the build to
> fail in my environment. We could just use memset() instead.
>
> At the same time, I received a compiler warning for strcpy(), as it is
> advised to use str[nl]cpy() instead. In this specific case we could
> argue we don't need to copy the string in the first place. The patch
> changes the code to just assign a constant string to a pointer.
Both changes LGTM.
Cheers,
Jon
>
> Best regards,
> --
> Ed Schouten <ed at 80386.nl <mailto:ed at 80386.nl>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
--
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded
More information about the cfe-commits
mailing list