[PATCH] MS ABI: Implement /volatile:ms
Alexey Bataev
a.bataev at hotmail.com
Thu Feb 12 01:59:12 PST 2015
================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:836
@@ -834,1 +835,3 @@
+ IsSeqCst ? llvm::SequentiallyConsistent
+ : llvm::Unordered);
// OpenMP, 2.12.6, atomic Construct
----------------
I'd say that if IsSeqCst is false, Atomic Ordering must be Monotonic rather than Unordered.
1. According to OpenMP 4.0 "non-sequentially consistent atomic construct has the same semantics as a
memory_order_relaxed atomic operation in C++11/C11.".
2. According to http://llvm.org/docs/Atomics.html "Monotonic... This corresponds to the C++11/C11 memory_order_relaxed"
http://reviews.llvm.org/D7580
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list