[clang-tools-extra] r228689 - The -I option needs a space, apparently, from the actual implementation.

[mats petersson]

Ah, yes, I guess that makes a difference ... Sorry for causing further
confusion. Although wouldn't it be nice if it was possible to use both
variants in both places? To be clear, that's a rhetorical question...

--
Mats

On 10 February 2015 at 16:02, Thompson, John
<John_Thompson at playstation.sony.com> wrote:
> Sorry for the confusion.  Were you thinking clang's argument processing? This has to do with the tooling argument processing, which apparently doesn't work if you don't have a space (or '=') separator.  I should have mentioned that in the commit comment.
>
> -John
>
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of mats petersson
> Sent: Tuesday, February 10, 2015 6:24 AM
> To: John Thompson
> Cc: cfe-commits
> Subject: Re: [clang-tools-extra] r228689 - The -I option needs a space, apparently, from the actual implementation.
>
> I thought there was a recent change to accept BOTH with and without space?
>
> --
> Mats
>
> On 10 February 2015 at 13:51, John Thompson <John.Thompson.JTSoftware at gmail.com> wrote:
>> Author: jtsoftware
>> Date: Tue Feb 10 07:51:17 2015
>> New Revision: 228689
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=228689&view=rev
>> Log:
>> The -I option needs a space, apparently, from the actual implementation.
>>
>> Modified:
>>     clang-tools-extra/trunk/docs/module-map-checker.rst
>>
>> Modified: clang-tools-extra/trunk/docs/module-map-checker.rst
>> URL:
>> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/modul
>> e-map-checker.rst?rev=228689&r1=228688&r2=228689&view=diff
>> ======================================================================
>> ========
>> --- clang-tools-extra/trunk/docs/module-map-checker.rst (original)
>> +++ clang-tools-extra/trunk/docs/module-map-checker.rst Tue Feb 10
>> +++ 07:51:17 2015
>> @@ -70,7 +70,7 @@ front-end arguments, which must follow t
>> Module-Map-Checker Command Line Options
>> =======================================
>>
>> -.. option:: -I(include path)
>> +.. option:: -I (include path)
>>
>>    Look at headers only in this directory tree.
>>    Must be a path relative to the module.map file.
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits