[PATCH] merge module-map-checker into modularize

John Thompson john.thompson.jtsoftware at gmail.com
Fri Feb 6 17:54:05 PST 2015


Sean,

The change for adding the recursion was a 4-line change:

@@ -374,9 +374,12 @@

  std::string File(I->path());
  I->status(Status);
  sys::fs::file_type Type = Status.type();

- // If the file is a directory, ignore the name.
- if (Type == sys::fs::file_type::directory_file)

+    // If the file is a directory, ignore the name and recurse.
+    if (Type == sys::fs::file_type::directory_file) {
+      if (!collectUmbrellaHeaders(File))
+        return false;

  continue;

+    }

  // If the file does not have a common header extension, ignore it.
  if (!isHeader(File))
    continue;

Because I basically copied a class from module-map-checker and hacked it a little, I can't really  subdivide the patch any further.

-John


http://reviews.llvm.org/D7475

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list