[PATCH] Add remote testing support to the lit config.

Dan Albert danalbert at google.com
Thu Feb 5 16:27:53 PST 2015


================
Comment at: test/libcxx/test/remote.py:223
@@ +222,3 @@
+        # For temp cleanup
+        self.remote_temp_files = []
+        self.remote_temp_dirs = []
----------------
jroelofs wrote:
> danalbert wrote:
> > Your naming is inconsistent. `self.scpCommand` but `self.remote_temp_files`. I prefer PEP8 stlye (with underscores), but LIT already chose the anti-Python style, so let's try to stick with that. (I'm guilty of this crime too.)
> as in camelCase for vars, and underscore_separated_functions() ? Ok.
Actually, looking at lit's Test.py, it looks like the format is underscores for variables, camel-case for functions.

http://reviews.llvm.org/D7380

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list