[PATCH] [MSVC] Improved lookup into dependent/non-dependent bases of dependent class

Reid Kleckner rnk at google.com
Thu Feb 5 09:49:11 PST 2015


================
Comment at: lib/Sema/SemaDecl.cpp:132
@@ +131,3 @@
+namespace {
+enum BasesLookupResult { NotFound, FoundNotType, FoundType };
+} // namespace
----------------
ABataev wrote:
> rsmith wrote:
> > rnk wrote:
> > > "FoundNonType" would be closer to the standardese terminology of "non-type template parameter"
> > This should either be an enum class or should use a prefix for its names; these identifiers seem too general to drop into global scope here.
> Turned enum into enum class and renamed FoundNotType to FoundNonTypeTemplateParam
Well, we aren't searching for template parameters specifically, so I'd still prefer FoundNonType. :)

http://reviews.llvm.org/D7173

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list