[PATCH] [libcxxabi] Fix -Werror build for 32-bit non-ARM.

Dan Albert danalbert at google.com
Wed Feb 4 15:22:13 PST 2015


Hi jroelofs, thakis,

The inclusion of Unwind-EHABI.h was insufficiently guarded
(LIBCXXABI_ARM_EHABI was beign checked without ever being defined).

Move the check into the header file itself, add the check to the
source file, and clean up the existing checks.

LIBCXXABI_ARM_EHABI didn't have a canonical defintion; it was
duplicated across cxxabi.h, libunwind.h, and unwind.h. Move the
definition into __cxxabi_config.h and clean up the old cruft (note: we
will have to ship this header).

There are also a few drive-by formatting/whitespace cleanups.

http://reviews.llvm.org/D7419

Files:
  include/__cxxabi_config.h
  include/cxxabi.h
  include/libunwind.h
  include/unwind.h
  src/Unwind/Unwind-EHABI.cpp
  src/Unwind/Unwind-EHABI.h
  src/Unwind/UnwindCursor.hpp
  src/Unwind/UnwindLevel1-gcc-ext.c
  src/cxa_exception.cpp
  src/cxa_exception.hpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7419.19357.patch
Type: text/x-patch
Size: 10321 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150204/c639d8ad/attachment.bin>


More information about the cfe-commits mailing list