r228107 - Generalize r228066 to give all implicit global allocation functions default visibility.
Larisse Voufo
lvoufo at google.com
Tue Feb 3 18:34:32 PST 2015
Author: lvoufo
Date: Tue Feb 3 20:34:32 2015
New Revision: 228107
URL: http://llvm.org/viewvc/llvm-project?rev=228107&view=rev
Log:
Generalize r228066 to give all implicit global allocation functions default visibility.
Added:
cfe/trunk/test/CodeGenCXX/implicit-allocation-functions.cpp
Removed:
cfe/trunk/test/CodeGenCXX/cxx14-implicit-sized-delete.cpp
Modified:
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Decl.cpp?rev=228107&r1=228106&r2=228107&view=diff
==============================================================================
--- cfe/trunk/lib/AST/Decl.cpp (original)
+++ cfe/trunk/lib/AST/Decl.cpp Tue Feb 3 20:34:32 2015
@@ -666,12 +666,7 @@ static LinkageInfo getLVForNamespaceScop
// Use global type/value visibility as appropriate.
Visibility globalVisibility;
if (computation == LVForValue) {
- const FunctionDecl *FD = D->getAsFunction();
- if (FD && FD->getCorrespondingUnsizedGlobalDeallocationFunction())
- // C++14's implicit sized deallocation functions always have default visibility.
- globalVisibility = DefaultVisibility;
- else
- globalVisibility = Context.getLangOpts().getValueVisibilityMode();
+ globalVisibility = Context.getLangOpts().getValueVisibilityMode();
} else {
assert(computation == LVForType);
globalVisibility = Context.getLangOpts().getTypeVisibilityMode();
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprCXX.cpp?rev=228107&r1=228106&r2=228107&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExprCXX.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprCXX.cpp Tue Feb 3 20:34:32 2015
@@ -2116,6 +2116,10 @@ void Sema::DeclareGlobalAllocationFuncti
SourceLocation(), Name,
FnType, /*TInfo=*/nullptr, SC_None, false, true);
Alloc->setImplicit();
+
+ // Implicit sized deallocation functions always have default visibility.
+ Alloc->addAttr(VisibilityAttr::CreateImplicit(Context,
+ VisibilityAttr::Default));
if (AddMallocAttr)
Alloc->addAttr(MallocAttr::CreateImplicit(Context));
Removed: cfe/trunk/test/CodeGenCXX/cxx14-implicit-sized-delete.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx14-implicit-sized-delete.cpp?rev=228106&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/cxx14-implicit-sized-delete.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/cxx14-implicit-sized-delete.cpp (removed)
@@ -1,27 +0,0 @@
-// RUN: %clang_cc1 -emit-llvm -triple x86_64-unknown-unknown -o - -std=c++14 %s 2>&1 | FileCheck %s -check-prefix=CHECKDEF -check-prefix=CHECK
-// RUN: %clang_cc1 -emit-llvm -triple x86_64-unknown-unknown -o - -std=c++14 -fvisibility hidden %s 2>&1 | FileCheck %s -check-prefix=CHECKHID -check-prefix=CHECK
-
-// PR22419: Implicit sized deallocation functions always have default visibility.
-
-// CHECKDEF-DAG: define void @_Z3fooPi(i32* %is)
-// CHECKHID-DAG: define hidden void @_Z3fooPi(i32* %is)
-void foo(int* is) {
-
- // CHECK-DAG: call void @_ZdlPvm(i8* %{{.+}}, i64 4)
- delete is;
-}
-
-// CHECK-DAG: define linkonce void @_ZdlPvm(i8*, i64)
-
-// CHECK-DAG: %struct.A = type { i8 }
-struct A { ~A() { }};
-
-// CHECKDEF-DAG: define void @_Z1fP1A(%struct.A* %p)
-// CHECKHID-DAG: define hidden void @_Z1fP1A(%struct.A* %p)
-void f(A *p) {
-
- // CHECK-DAG: call void @_ZdaPvm(i8* %{{.+}}, i64 %{{.+}})
- delete[] p;
-}
-
-// CHECK-DAG: define linkonce void @_ZdaPvm(i8*, i64)
Added: cfe/trunk/test/CodeGenCXX/implicit-allocation-functions.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/implicit-allocation-functions.cpp?rev=228107&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/implicit-allocation-functions.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/implicit-allocation-functions.cpp Tue Feb 3 20:34:32 2015
@@ -0,0 +1,54 @@
+// RUN: %clang_cc1 -emit-llvm -triple %itanium_abi_triple -o - -std=c++11 %s 2>&1 | FileCheck %s -check-prefix=CHECKDEF -check-prefix=CHECK11
+// RUN: %clang_cc1 -emit-llvm -triple %itanium_abi_triple -o - -std=c++11 -fvisibility hidden %s 2>&1 | FileCheck %s -check-prefix=CHECKHID -check-prefix=CHECK11
+// RUN: %clang_cc1 -emit-llvm -triple %itanium_abi_triple -o - -std=c++14 %s 2>&1 | FileCheck %s -check-prefix=CHECKDEF -check-prefix=CHECK14
+// RUN: %clang_cc1 -emit-llvm -triple %itanium_abi_triple -o - -std=c++14 -fvisibility hidden %s 2>&1 | FileCheck %s -check-prefix=CHECKHID -check-prefix=CHECK14
+
+// PR22419: Implicit sized deallocation functions always have default visibility.
+// Generalized to all implicit allocation functions.
+
+
+// CHECK14-DAG: %struct.A = type { i8 }
+struct A { };
+
+// CHECKDEF-DAG: define void @_Z3fooP1A(%struct.A* %is)
+// CHECKHID-DAG: define hidden void @_Z3fooP1A(%struct.A* %is)
+void foo(A* is) {
+
+ // CHECK11-DAG: call noalias i8* @_Znwm(i64 1)
+ // CHECK14-DAG: call noalias i8* @_Znwm(i64 1)
+ is = new A();
+
+ // CHECK11-DAG: call void @_ZdlPv(i8* %{{.+}})
+ // CHECK14-DAG: call void @_ZdlPvm(i8* %{{.+}}, i64 1)
+ delete is;
+}
+
+// CHECK11-DAG: declare noalias i8* @_Znwm(i64)
+// CHECK11-DAG: declare void @_ZdlPv(i8*)
+
+// CHECK14-DAG: declare noalias i8* @_Znwm(i64)
+// CHECK14-DAG: define linkonce void @_ZdlPvm(i8*, i64)
+// CHECK14-DAG: declare void @_ZdlPv(i8*)
+
+// CHECK14-DAG: %struct.B = type { i8 }
+struct B { ~B() { }};
+
+// CHECKDEF-DAG: define void @_Z1fP1B(%struct.B* %p)
+// CHECKHID-DAG: define hidden void @_Z1fP1B(%struct.B* %p)
+void f(B *p) {
+
+ // CHECK11-DAG: call noalias i8* @_Znam(i64 13)
+ // CHECK14-DAG: call noalias i8* @_Znam(i64 13)
+ p = new B[5];
+
+ // CHECK11-DAG: call void @_ZdaPv(i8* %{{.+}})
+ // CHECK14-DAG: call void @_ZdaPvm(i8* %{{.+}}, i64 %{{.+}})
+ delete[] p;
+}
+
+// CHECK11-DAG: declare noalias i8* @_Znam(i64)
+// CHECK11-DAG: declare void @_ZdaPv(i8*)
+
+// CHECK14-DAG: declare noalias i8* @_Znam(i64)
+// CHECK14-DAG: define linkonce void @_ZdaPvm(i8*, i64)
+// CHECK14-DAG: declare void @_ZdaPv(i8*)
More information about the cfe-commits
mailing list