[PATCH] Allow to specify multiple -fsanitize-blacklist= arguments.

Alexey Samsonov vonosmas at gmail.com
Tue Feb 3 13:49:56 PST 2015


================
Comment at: lib/Driver/SanitizerArgs.cpp:300
@@ -292,12 +299,3 @@
       std::string BLPath = BLArg->getValue();
-      if (llvm::sys::fs::exists(BLPath)) {
-        // Validate the blacklist format.
-        std::string BLError;
-        std::unique_ptr<llvm::SpecialCaseList> SCL(
-            llvm::SpecialCaseList::create(BLPath, BLError));
-        if (!SCL.get())
-          D.Diag(clang::diag::err_drv_malformed_sanitizer_blacklist) << BLError;
-        else
-          BlacklistFile = BLPath;
-      } else {
+      if (!llvm::sys::fs::exists(BLPath)) {
         D.Diag(clang::diag::err_drv_no_such_file) << BLPath;
----------------
timurrrr wrote:
> nit: I find
> 
>   if (llvm::sys::fs::exists(BLPath))
>     BlacklistFiles.push_back(BLPath);
>   else
>     D.Diag(clang::diag::err_drv_no_such_file) << BLPath;
> 
> shorter and easier to understand
Done

================
Comment at: lib/Driver/SanitizerArgs.cpp:305
@@ +304,3 @@
+      BlacklistFiles.push_back(BLPath);
+    } else if (BLArg->getOption().matches(
+                   options::OPT_fno_sanitize_blacklist)) {
----------------
timurrrr wrote:
> very nitty nit: you can fit into 80 chars if you shorten `BLArg` to say `Arg`?
Done

http://reviews.llvm.org/D7368

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list