[PATCH] [libcxx] Add <experimental/system_error>

Marshall Clow mclow.lists at gmail.com
Tue Feb 3 11:42:17 PST 2015


Looks good to me.


================
Comment at: test/std/experimental/utilities/syserror/header.system_error.synop/is_error_condition_enum.pass.cpp:24
@@ +23,3 @@
+
+    static_assert(ex::is_error_condition_enum_v<std::errc> ==
+                  std::is_error_condition_enum<std::errc>::value, "");
----------------
You know, if I was writing this, I would align stuff to make it clear what's the same and what's different.

    static_assert( ex::is_error_condition_enum_v<std::errc> ==
                  std::is_error_condition_enum  <std::errc>::value, "" );

But that might just be me indulging my OCD.

http://reviews.llvm.org/D7353

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list