[PATCH] [clang-tidy] Checker for inefficient use of algorithms on associative containers

Gábor Horváth xazax.hun at gmail.com
Tue Feb 3 07:46:35 PST 2015


Thanks for the review.

- I have added support for unordered containers. There is no comparator check for the unordered containers and there is no lower or upper bound member functions. Code to deal with these cases was added.
- I made the matcher more strict with equalBoundNodes as you suggested.
- The warning messages was modified as you requested. Unfortunately I do not have a native speaker coworker to check these messages.
- Replaced the string concatenations with twine operations.


http://reviews.llvm.org/D7246

Files:
  clang-tidy/misc/CMakeLists.txt
  clang-tidy/misc/InefficientAlgorithmCheck.cpp
  clang-tidy/misc/InefficientAlgorithmCheck.h
  clang-tidy/misc/MiscTidyModule.cpp
  test/clang-tidy/misc-inefficient-algorithm.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7246.19224.patch
Type: text/x-patch
Size: 11341 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150203/d7df9ed6/attachment.bin>


More information about the cfe-commits mailing list