[PATCH] [libcxx] Add <experimental/chrono>

Marshall Clow mclow.lists at gmail.com
Mon Feb 2 12:10:42 PST 2015


Other than the namespace issue, this looks good.


================
Comment at: include/experimental/chrono:42
@@ +41,3 @@
+
+namespace std { namespace chrono { namespace experimental {
+    inline namespace fundamentals_v1 {
----------------
I think this needs to go into `std::__1::chrono`

So we could write
    _LIBCPP_BEGIN_NAMESPACE_STD
    namespace chrono {
        namespace experimental { inline namespace fundamentals_v1 {

Maybe there needs to be a macro for this; or just for the "namespace experimental { inline namespace fundamentals_v1 {`" part.

http://reviews.llvm.org/D7352

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list