[PATCH] Split unwind register save/restore files per-function, and appease the assembler.

[Renato Golin]

================
Comment at: Unwind/CMakeLists.txt:25
@@ -15,1 +24,3 @@
+  UnwindRegistersSave_saveiWMMX.S
+  UnwindRegistersSave_unw_getcontext.S
 )
----------------
jroelofs wrote:
> compnerd wrote:
> > It would be nice to split these on architecture boundary and keep the variants in a single file.  Something like:
> > 
> >     UnwindRegistersRestore-${ARCH}.S
> >     UnwindRegistersSave-${ARCH}.S
> > 
> > Might be nice to do that for the current save/restore file as a setup change.
> I split them per-function so that there was no possible way a `.fpu` directive accidentally applied to something it shouldn't. If we could push & pop fpu states, I'd be less worried about it.
In my local patch, I separated by arch, too and left the newer fpus for the last. Push/pop support may come in this year, but that will mean we'll need ifdefs for gcc compiling it...

I see what you're worrying about, but these functions will never matter, because the .fpu is only to let the assembler compile that, not to make it run on a hardware that doesn't have vfp. I personally think one same per arch would be best...

http://reviews.llvm.org/D7258

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/