Are those if conditions that span to the next line indented correctly? Apart from this nitpick, LGTM. http://reviews.llvm.org/D7245 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/