r227088 - For NetBSD/ARM-EB, link with --be8. Support for the older BE32 is

[Joerg Sonnenberger]

On Wed, Jan 28, 2015 at 01:15:48PM -0800, Tim Northover wrote:
> Hi Joerg,
> 
> > as discussed on IRC, another version of the patch with inverted
> > branches.
> 
> I think I mentioned more things than inverting branches:
> 
>   + I think we should be using Triple::getSubArch rather than string matching.

(a) getSubArch would decouple it from -march, which IMO makes sense to
also recognize. If you request ARMv7 or ARMv8 as codegen target, it
doesn't make sense to produce a binary that can't run on it.

(b) string match vs using enum would normally make me lean toward the
second, but we can't really get coverage testing here as SubArchType is
not ARM specific.

>   + It needs to be plumbed into gnutools::Link; I'd prefer the other
> BSDs too (at least if they show hints of ARM & BE support), but that's
> not fatal because we may be incorrect about the desired behaviour and
> to my knowledge they haven't said anything.

As I said, I don't know what Linux wants, so hooking it up has to be
done by someone who at least can test the correctness.

Joerg