r226955 - DebugInfo: Remove outdated comment. Column info is no longer needed to differentiate inline callsites.
David Blaikie
dblaikie at gmail.com
Fri Jan 23 14:48:27 PST 2015
Author: dblaikie
Date: Fri Jan 23 16:48:27 2015
New Revision: 226955
URL: http://llvm.org/viewvc/llvm-project?rev=226955&view=rev
Log:
DebugInfo: Remove outdated comment. Column info is no longer needed to differentiate inline callsites.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExpr.cpp?rev=226955&r1=226954&r2=226955&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGExpr.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGExpr.cpp Fri Jan 23 16:48:27 2015
@@ -3059,12 +3059,6 @@ RValue CodeGenFunction::EmitRValueForFie
RValue CodeGenFunction::EmitCallExpr(const CallExpr *E,
ReturnValueSlot ReturnValue) {
- // Force column info to be generated so we can differentiate
- // multiple call sites on the same line in the debug info.
- // FIXME: This is insufficient. Two calls coming from the same macro
- // expansion will still get the same line/column and break debug info. It's
- // possible that LLVM can be fixed to not rely on this uniqueness, at which
- // point this workaround can be removed.
ApplyDebugLocation DL(*this, E->getLocStart());
// Builtins never have block type.
More information about the cfe-commits
mailing list