[PATCH] [Mips] Fix type of 64-bit integer in case of MIPS N64 ABI
Daniel Sanders
daniel.sanders at imgtec.com
Thu Jan 22 11:59:12 PST 2015
Thanks for fixing this so quickly. LGTM with a small correction. We haven't changed 'long long' itself so we shouldn't change its LL constant suffix on __LONG_LONG_MAX__ to L.
================
Comment at: test/Preprocessor/init.c:3739
@@ -3124,3 +3738,3 @@
// MIPS64BE:#define __LDBL_MIN__ 3.36210314311209350626267781732175260e-4932L
-// MIPS64BE:#define __LONG_LONG_MAX__ 9223372036854775807LL
+// MIPS64BE:#define __LONG_LONG_MAX__ 9223372036854775807L
// MIPS64BE:#define __LONG_MAX__ 9223372036854775807L
----------------
This one should stay as LL since we haven't changed long long itself.
================
Comment at: test/Preprocessor/init.c:3947
@@ -3332,3 +3946,3 @@
// MIPS64EL:#define __LITTLE_ENDIAN__ 1
-// MIPS64EL:#define __LONG_LONG_MAX__ 9223372036854775807LL
+// MIPS64EL:#define __LONG_LONG_MAX__ 9223372036854775807L
// MIPS64EL:#define __LONG_MAX__ 9223372036854775807L
----------------
This one should stay LL since we haven't changed long long itself
http://reviews.llvm.org/D7127
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list