[PATCH] [libcxxabi] Teach CMake better ways to find the libc++ source directory (and misc cleanup).

[Jonathan Roelofs]

================
Comment at: CMakeLists.txt:149
@@ +148,3 @@
+if (LIBCXXABI_LIBCXX_PATH STREQUAL "LIBCXXABI_LIBCXX_PATH-NOTFOUND")
+  message(WARNING "LIBCXXABI_LIBCXX_PATH was not specified and couldn't be infered.")
+  set(LIBCXXABI_LIBCXX_PATH "")
----------------
shouldn't this be an error?

================
Comment at: test/lit.cfg:29
@@ -28,4 +28,3 @@
 # and libcxxabi source directories are sibling directories.
-libcxx_source_root = getattr(config, 'libcxx_source_root',
-                             os.path.join(config.test_source_root,
-                                          '../../libcxx'))
+libcxx_source_root = getattr(config, 'libcxx_src_root', None)
+if not libcxx_source_root:
----------------
may as well s/_source_/_src_/ while you're here.

================
Comment at: test/lit.cfg:51
@@ -50,3 +50,3 @@
     site_cfg = lit_config.params.get('libcxxabi_site_config',
-                                     os.environ.get('LIBCXX_SITE_CONFIG'))
     if not site_cfg:
----------------
oops, good catch.

http://reviews.llvm.org/D7130

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/