[PATCH] Merge libc++abi's lit configuration with libc++'s

Dan Albert danalbert at google.com
Wed Jan 21 14:42:24 PST 2015


================
Comment at: CMakeLists.txt:47
@@ +46,3 @@
+
+  add_custom_target(check-libcxxabi
+    COMMAND ${PYTHON_EXECUTABLE}
----------------
What prevents us from continuing to  use `add_lit_testsuite`? If I'm reading the definition correctly, the function will automatically use `LLVM_LIT_ARGS` (used indirectly in `add_lit_target). That also keeps the `FindPythonInterp` stuff delegated to the LLVM cmake code.

================
Comment at: libcxxabi/test/config.py:43
@@ +42,3 @@
+        libcxxabi_headers = self.get_lit_conf('libcxxabi_headers',
+                                              self.libcxxabi_src_root + '/include')
+        if not os.path.isdir(libcxxabi_headers):
----------------
`os.path.join` (The leading slash isn't necessary with `os.path.join`. I'd like to believe Windows will handle that gracefully, but I don't actually know.)

http://reviews.llvm.org/D6985

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list