[patch][pr22217] Use the most recent decl for mangling

David Majnemer david.majnemer at gmail.com
Tue Jan 20 09:42:12 PST 2015


I don't think this approach would handle things like:

int pr22217_foo;
int *b = &pr22217_foo;
extern int pr22217_foo __asm__("pr22217_bar");

With your patch, pr22217_foo gets emitted.
With gcc, pr22217_bar gets emitted.

On Tue, Jan 20, 2015 at 7:30 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> Sorry, I attached an older version of the patch. This one has a
> slightly simpler test.
>
> On 20 January 2015 at 10:29, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
> > Currently clang will produce a @foo when given
> >
> > int foo;
> > extern int foo __asm__("bar");
> >
> > The attached patch makes it produce a @bar, which is what gcc produces.
> >
> > I am confused by the output changes in the microsoft abi tests.
> > Hopefully someone more familiar with it can comment on why using a
> > more recent decl causes problems and has an idea of what should be
> > changed to accommodate it.
> >
> > Cheers,
> > Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150120/5afc835e/attachment.html>


More information about the cfe-commits mailing list