[PATCH] Adding option -fno-inline-asm to disallow inline asm

Eric Christopher echristo at gmail.com
Fri Jan 16 14:22:04 PST 2015


Couple small inline nits, otherwise LGTM.

-eric


================
Comment at: lib/Driver/Tools.cpp:4323
@@ -4322,1 +4322,3 @@
 
+  // -fgnu-inline-asm is default
+  if (!Args.hasFlag(options::OPT_fgnu_inline_asm,
----------------
Period at the end of the sentence.

================
Comment at: lib/Parse/ParseStmtAsm.cpp:619
@@ +618,3 @@
+
+  // Check if GNU-style inline Asm is disabled
+  if (!getLangOpts().GNUAsm)
----------------
Periods at the end of sentences.

================
Comment at: test/Parser/ms-inline-asm.c:3
@@ -2,1 +2,3 @@
 // RUN: %clang_cc1 %s -triple i386-apple-darwin10 -verify -fasm-blocks
+// disable gnu inline asm should have no effects on this testcase
+// RUN: %clang_cc1 %s -triple i386-apple-darwin10 -verify -fasm-blocks -fno-gnu-inline-asm
----------------
"Disabling gnu inline assembly should have no effect on this testcase."

http://reviews.llvm.org/D6870

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list