[PATCH][OPENCL][SPIR] introduce SPIR calling conventions

Pekka Jääskeläinen pekka.jaaskelainen at tut.fi
Fri Jan 16 07:03:06 PST 2015


On 01/15/2015 05:28 AM, Sameer Sahasrabuddhe wrote:
>
> This implements Section 3.7 from the SPIR 1.2 spec:
>
>          SPIR kernels should use "spir_kernel" calling convention.
>          Non-kernel functions use "spir_func" calling convention. All
>          other calling conventions are disallowed.
>
> The patch works only for OpenCL source. Any other uses will need to ensure
> that kernels are assigned the spir_kernel calling convention correctly.
>
> Note that the patch modifies how ASTContext determines the default calling
> convention. This *may* need a closer look, but it does pass lit tests on all
> targets.

It looks fine to me.

-- 
Pekka



More information about the cfe-commits mailing list