[PATCH] Implementation for completion in call context for C++

Francisco Lopes da Silva francisco.mailing.lists at oblita.com
Thu Jan 15 18:54:15 PST 2015


In http://reviews.llvm.org/D6880#109626, @francisco.lopes wrote:

> In http://reviews.llvm.org/D6880#109513, @francisco.lopes wrote:
>
> > Refactoring
> >
> > - Followed all points by Manuel Klimek except for the one targeting `suppressDiagnostics()`.
>
>
> Looking elsewhere and in docs, it seems `suppressDiagnostics()` is better to be used since diagnostics in lookups just for completion are not expected.


I've tried a build without this line just to check whether I could get any effect, but no, it didn't make a difference as far as I can see, so...  ¯\_(ツ)_/¯.


http://reviews.llvm.org/D6880

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list