[PATCH] Implement command line options for stack probe space

[David Majnemer]

LGTM with nits fixed.


REPOSITORY
  rL LLVM

================
Comment at: include/clang/Driver/CLCompatOptions.td:65
@@ -64,1 +64,3 @@
   Alias<fwritable_strings>;
+def _SLASH_Gs : CLJoined<"Gs">, HelpText<"Set stack probe size">, 
+  Alias<mstack_probe_size>;
----------------
Please remove trailing whitespace here.

================
Comment at: include/clang/Frontend/CodeGenOptions.def:141
@@ -140,1 +140,3 @@
                                             ///< alignment, if not 0.
+VALUE_CODEGENOPT(StackProbeSize    , 32, 4096) ///< Overrides default stack 
+                                               ///< probe size, even if 0.
----------------
Please remove trailing whitespace here.

================
Comment at: lib/CodeGen/TargetInfo.cpp:1639
@@ +1638,3 @@
+                                             CodeGen::CodeGenModule &CGM) {
+  if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
+    if (CGM.getCodeGenOpts().StackProbeSize != 4096) {
----------------
You don't actually use the result of the `dyn_cast`, please use `isa` instead.

http://reviews.llvm.org/D6685

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/