r225963 - clang-format: [Java] Don't line-wrap before annotations' l_parens.
Daniel Jasper
djasper at google.com
Wed Jan 14 01:51:33 PST 2015
Author: djasper
Date: Wed Jan 14 03:51:32 2015
New Revision: 225963
URL: http://llvm.org/viewvc/llvm-project?rev=225963&view=rev
Log:
clang-format: [Java] Don't line-wrap before annotations' l_parens.
Before:
@SomeAnnotation
(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)
int i;
After:
@SomeAnnotation(
aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)
int i;
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJava.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=225963&r1=225962&r2=225963&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Wed Jan 14 03:51:32 2015
@@ -1939,7 +1939,7 @@ bool TokenAnnotator::canBreakBefore(cons
if (Left.Tok.getObjCKeywordID() == tok::objc_interface)
return false;
if (Left.isOneOf(TT_JavaAnnotation, TT_LeadingJavaAnnotation))
- return true;
+ return !Right.is(tok::l_paren);
if (Right.isOneOf(TT_StartOfName, TT_FunctionDeclarationName) ||
Right.is(tok::kw_operator))
return true;
Modified: cfe/trunk/unittests/Format/FormatTestJava.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTestJava.cpp?rev=225963&r1=225962&r2=225963&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTestJava.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTestJava.cpp Wed Jan 14 03:51:32 2015
@@ -279,6 +279,10 @@ TEST_F(FormatTestJava, Annotations) {
verifyFormat("@Test(a)\n"
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
" aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);");
+ verifyFormat("@SomeAnnotation(\n"
+ " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)\n"
+ "int i;",
+ getStyleWithColumns(50));
}
TEST_F(FormatTestJava, Generics) {
More information about the cfe-commits
mailing list