[PATCH] Fix assertion in BreakableBlockComment (http://llvm.org/PR21916).
Daniel Jasper
djasper at google.com
Mon Jan 12 01:43:45 PST 2015
Looks good.
================
Comment at: lib/Format/BreakableToken.h:215
@@ -214,1 +214,3 @@
// a "*" prefix.
+ // The first line's target column is always positive. The rest lines' target
+ // columns are relative to the first line to allow correct indentation of
----------------
nit: The remaining lines' ...
================
Comment at: lib/Format/BreakableToken.h:217
@@ +216,3 @@
+ // columns are relative to the first line to allow correct indentation of
+ // comments in \c WhitespaceManager, so they can be negative as well (in case
+ // the first line needs to be unindented more than there's actual whitespace
----------------
nit: .. \c WhitespaceManager. Thus, they ...
http://reviews.llvm.org/D6894
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list