[PATCH] [libc++] Refactor test components into modules.

Dan Albert danalbert at google.com
Thu Jan 8 14:18:39 PST 2015


In http://reviews.llvm.org/D6881#106471, @EricWF wrote:

> Woops, I misunderstood the layout of this patch. I would still like to see the configuration live somewhere else. The currently layout seems needlessly complicated. Also I think it could live in `libcxx/test` instead of `libcxx/test/libcxx`, leaving `libcxx/test/libcxx` to only contain tests.


I had considered adding them directly to `<libcxx-root>/test/` and having the `sys.path` be `<libcxx-root>/..`, but since the root isn't guaranteed to be named `libcxx`, you can't reliably import it. We can't set the `sys.path` to `<libcxx-root>`, because then they would be imported as `import test.libcxxconfig` (or whatever), and we need a more unique name for our top level package (there is already a `test` package). If we're willing to say that your top level directory //must// be named `libcxx`, then I'd be happy adding them directly to `<libcxx-root>/test`.

> Also, @jroelofs doesn't want any generated files. Could we use `sys.dont_write_bytecode = True` in `lit.cfg` to turn this off? This way SVN users won't have to worry about generated .pyc files either, and we keep the source directory clean.


Ah, my mistake. I have `.py[cod]` in my global `.gitignore`, so I hadn't noticed it. I'll add the local `.gitignore` and be sure to set the svn props.


http://reviews.llvm.org/D6881

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list