[PATCH] Add the Altivec __bool keyword for better gcc compatibility
Bill Seurer
seurer at linux.vnet.ibm.com
Thu Jan 8 12:28:30 PST 2015
Hi wschmidt, willschm, echristo, hfinkel,
To provide better compatibility with gcc I added the __bool keyword to the Alitivec support in clang. __bool is functionally identical to using bool when declaring vector types. For example:
vector bool char v_bc;
vector __bool char v___bc;
clang already supported __vector and __pixel but was missing __bool for some reason.
For reference: https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/PowerPC-AltiVec_002fVSX-Built-in-Functions.html
http://reviews.llvm.org/D6882
Files:
/home/seurer/llvm/llvm-checkin/tools/clang/include/clang/Basic/TokenKinds.def
/home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseDecl.cpp
/home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseTentative.cpp
/home/seurer/llvm/llvm-checkin/tools/clang/test/Parser/altivec.c
Index: /home/seurer/llvm/llvm-checkin/tools/clang/include/clang/Basic/TokenKinds.def
===================================================================
--- /home/seurer/llvm/llvm-checkin/tools/clang/include/clang/Basic/TokenKinds.def
+++ /home/seurer/llvm/llvm-checkin/tools/clang/include/clang/Basic/TokenKinds.def
@@ -497,6 +497,7 @@
// Altivec Extension.
KEYWORD(__vector , KEYALTIVEC)
KEYWORD(__pixel , KEYALTIVEC)
+KEYWORD(__bool , KEYALTIVEC)
// ARM NEON extensions.
ALIAS("__fp16", half , KEYALL)
Index: /home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseDecl.cpp
===================================================================
--- /home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseDecl.cpp
+++ /home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseDecl.cpp
@@ -3200,6 +3200,9 @@
case tok::kw___pixel:
isInvalid = DS.SetTypeAltiVecPixel(true, Loc, PrevSpec, DiagID, Policy);
break;
+ case tok::kw___bool:
+ isInvalid = DS.SetTypeAltiVecBool(true, Loc, PrevSpec, DiagID, Policy);
+ break;
case tok::kw___unknown_anytype:
isInvalid = DS.SetTypeSpecType(TST_unknown_anytype, Loc,
PrevSpec, DiagID, Policy);
@@ -6035,6 +6038,7 @@
case tok::kw_float:
case tok::kw_double:
case tok::kw_bool:
+ case tok::kw___bool:
case tok::kw___pixel:
Tok.setKind(tok::kw___vector);
return true;
@@ -6068,6 +6072,7 @@
case tok::kw_float:
case tok::kw_double:
case tok::kw_bool:
+ case tok::kw___bool:
case tok::kw___pixel:
isInvalid = DS.SetTypeAltiVecVector(true, Loc, PrevSpec, DiagID, Policy);
return true;
Index: /home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseTentative.cpp
===================================================================
--- /home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseTentative.cpp
+++ /home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseTentative.cpp
@@ -992,6 +992,7 @@
case tok::kw___unaligned:
case tok::kw___vector:
case tok::kw___pixel:
+ case tok::kw___bool:
case tok::kw__Atomic:
case tok::kw___unknown_anytype:
return TPResult::False;
Index: /home/seurer/llvm/llvm-checkin/tools/clang/test/Parser/altivec.c
===================================================================
--- /home/seurer/llvm/llvm-checkin/tools/clang/test/Parser/altivec.c
+++ /home/seurer/llvm/llvm-checkin/tools/clang/test/Parser/altivec.c
@@ -18,6 +18,9 @@
__vector bool char vv_bc;
__vector bool short vv_bs;
__vector bool int vv_bi;
+__vector __bool char vv___bc;
+__vector __bool short vv___bs;
+__vector __bool int vv_bi;
__vector __pixel vv_p;
__vector pixel vv__p;
__vector int vf__r();
@@ -40,6 +43,9 @@
vector bool char v_bc;
vector bool short v_bs;
vector bool int v_bi;
+vector __bool char v___bc;
+vector __bool short v___bs;
+vector __bool int v___bi;
vector __pixel v_p;
vector pixel v__p;
vector int f__r();
@@ -64,6 +70,7 @@
__vector long double vv_ld; // expected-error {{cannot use 'long double' with '__vector'}}
vector long double v_ld; // expected-error {{cannot use 'long double' with '__vector'}}
vector bool v_b; // expected-warning {{type specifier missing, defaults to 'int'}}
+vector __bool v___b; // expected-warning {{type specifier missing, defaults to 'int'}}
// These should have errors.
__vector double vv_d1; // expected-error {{use of 'double' with '__vector' requires VSX support to be enabled (available on the POWER7 or later)}}
@@ -77,6 +84,13 @@
vector bool unsigned int v_bsc2; // expected-error {{cannot use 'unsigned' with '__vector bool'}}
vector bool long v_bl; // expected-error {{cannot use 'long' with '__vector bool'}}
vector bool long long v_bll; // expected-error {{cannot use 'long long' with '__vector bool'}}
+vector __bool float v___bf; // expected-error {{cannot use 'float' with '__vector bool'}}
+vector __bool double v___bd; // expected-error {{cannot use 'double' with '__vector bool'}}
+vector __bool pixel v___bp; // expected-error {{cannot use '__pixel' with '__vector bool'}}
+vector __bool signed char v___bsc; // expected-error {{cannot use 'signed' with '__vector bool'}}
+vector __bool unsigned int v___bsc2; // expected-error {{cannot use 'unsigned' with '__vector bool'}}
+vector __bool long v___bl; // expected-error {{cannot use 'long' with '__vector bool'}}
+vector __bool long long v___bll; // expected-error {{cannot use 'long long' with '__vector bool'}}
// vector long is deprecated, but vector long long is not.
vector long long v_ll;
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6882.17905.patch
Type: text/x-patch
Size: 4768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150108/277592b7/attachment.bin>
More information about the cfe-commits
mailing list