[PATCH] [libc++] Refactor test components into modules.

Dan Albert danalbert at google.com
Thu Jan 8 12:22:03 PST 2015


Hi EricWF, jroelofs, mclow.lists,

I've moved the bulk of `lit.cfg` into `test/libcxx/testconfig.py` and
`test/libcxx/testformat.py`. All that remains in `lit.cfg` is the
logic to discover lit.site.cfg if lit.cfg was run directly, and the
logic for loading configuration variants.

The configuration variant flow has changed with this patch. Rather
than instantiating an object of type `<VARIANT>Configuration`, we now
instatiate an object of type `Configuration` that was loaded from the
module `<VARIANT>.testconfig.py`.

This has to be done on a per-project basis rather than in LIT itself
because LIT doesn't actually know where the real test directory is,
only where the site configuration is (which is usually in the output
directory). It's simple enough to do though, so it's fine to require
each project to do it themselves.

I also cleaned up all the pylint issues while I was here, which was
mostly just a matter of fixing long lines.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6881

Files:
  test/libcxx/__init__.py
  test/libcxx/testconfig.py
  test/libcxx/testformat.py
  test/lit.cfg

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6881.17906.patch
Type: text/x-patch
Size: 53827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150108/2a55a2a4/attachment.bin>


More information about the cfe-commits mailing list